chore: Button Style API refactor #3752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodoranemes
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3752 +/- ##
=======================================
Coverage 97.01% 97.01%
=======================================
Files 825 826 +1
Lines 23963 23965 +2
Branches 8427 8357 -70
=======================================
+ Hits 23248 23250 +2
Misses 666 666
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
teodoranemes
changed the title
avinashbot
approved these changes
Aug 13, 2025
| import { ButtonProps } from './interfaces'; | ||
|
|
||
| export function getButtonStyles(style: ButtonProps['style']) { | ||
| if (SYSTEM !== 'core' || !style?.root) { |
There was a problem hiding this comment.
Minor: just out of curiosity, I know we have this for bundlers/minifiers to remove, but I don't know how complex this is allowed to be. For example, are you allowed to combine it with other conditionals like this?
Do you know if there's a way to test this? Got curious, did some research:
- Webpack uses Terser, which removes replaced conditionals
- Vite uses esbuild, which does not
Oh well, probably need to come up with something smarter eventually. But that's for later, this isn't a valid reason to block this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
stylefile for the Button component to maintain consistency across all Style API Components.How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.